Skip to content

Conversation

epage
Copy link
Contributor

@epage epage commented Dec 17, 2024

This reverts #354 and #429 to unblock people while a better solution for #340 and #428 is found.

Fixes #531
Fixes #522
Fixes #609

@coveralls
Copy link

coveralls commented Dec 17, 2024

Pull Request Test Coverage Report for Build 12380828834

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 61.745%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/env.rs 1 2 50.0%
src/config.rs 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
src/value.rs 1 37.62%
Totals Coverage Status
Change from base Build 12379967077: -0.1%
Covered Lines: 920
Relevant Lines: 1490

💛 - Coveralls

@epage epage merged commit b03a0f5 into rust-cli:main Dec 17, 2024
14 of 15 checks passed
@epage epage deleted the lower branch December 17, 2024 20:27
primeos-work added a commit to primeos-work/butido that referenced this pull request Dec 30, 2024
We had to revert the update to version 0.14 in 4c6f027 due to a
breaking change that made the `config` crate case-insensitive regarding
configuration keys/settings.
The impact of that upstream change/"regression" was tracked in [0],
the change finally got reverted in [1], and version 0.15.0 was released
with the original (case-sensitive) behaviour.

[0]: rust-cli/config-rs#531
[1]: rust-cli/config-rs#613

Signed-off-by: Michael Weiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants