[needs test] always shell-escape command arguments after failure #5666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rust-lang#5665 remove the `debug_string` method, in favour of always using the `fat::Display` impl. `debug_string` didn’t escape the command arguments, so that’s why we ended up with unescaped arguments after compilation failed
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Nice! r=me with a test |
The doesn’t doesn’t seem to run when I run `cargo test` though
|
@bors: r+ Thanks! |
|
📌 Commit 727684d has been approved by |
bors
added a commit
that referenced
this pull request
Jul 3, 2018
[needs test] always shell-escape command arguments after failure cc @joshtriplett fixes #5665 Removes the `debug_string` method, in favour of always using the `fmt::Display` impl. `debug_string` didn’t escape the command arguments, so that’s why we ended up with unescaped arguments after compilation failed. Don't merge this yet, because I still want to add a regression test. I don't think there's any tests on shell quoting yet, so I'll probably add a new test file including tests for the "Running <command>" output too. I still have to figure out how to write tests, and don't have the energy to do that tonight 😴 I just wanted to say, by the way, I was pleasantly surprised with how clean the code is in this repo, especially compared to rustc. It made it really easy to find the relevant part of the code and implement these changes.
|
☀️ Test successful - status-appveyor, status-travis |
mikeyhew
added a commit
to mikeyhew/cargo
that referenced
this pull request
Jul 4, 2018
Even with rust-lang#5666, when commands are shown in verbose output, there are still some cases where they can’t be run in the terminal. This is because the code is expecting certain environment variables that are provided by cargo. This PR updates the `Display` impl for `ProcessBuilder` to show the environment variables in front of the command (on unix), so that the command can be run. Note that for workspaces, you will still have to run the command from the workspace root. I deliberately didn’t update any of the tests yet, because I want to see if this is desired, and figure out if there is a way to do this on windows.
bors
added a commit
that referenced
this pull request
Jul 6, 2018
Fix the shell_quoting test r? @alexcrichton add-on to #5666 - Added `mod shell_quoting;` to testsuite/main.rs, so it actually runs - fixed bugs in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @joshtriplett
fixes #5665
Removes the
debug_stringmethod, in favour of always using thefmt::Displayimpl.debug_stringdidn’t escape the commandarguments, so that’s why we ended up with unescaped arguments after
compilation failed.
Don't merge this yet, because I still want to add a regression test. I don't think there's any tests on shell quoting yet, so I'll probably add a new test file including tests for the "Running " output too. I still have to figure out how to write tests, and don't have the energy to do that tonight 😴
I just wanted to say, by the way, I was pleasantly surprised with how clean the code is in this repo, especially compared to rustc. It made it really easy to find the relevant part of the code and implement these changes.