Fix the shell_quoting test #5680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `mod shell_quoting` to testsuite/main.rs - fixed up errors in the test, now that the test suite knows about it
Member
|
@bors: r+ |
Contributor
|
📌 Commit d1cb78a has been approved by |
Contributor
|
⌛ Testing commit d1cb78a with merge 623185438493056c5584002c019d8705c4c138d9... |
Contributor
|
💔 Test failed - status-appveyor |
Contributor
Author
|
The test is failing on windows because
What do you think? |
Member
|
I think env vars can be used to trick it into always doing unix escaping, so perhaps that could be used? |
Contributor
Author
|
Sure, I'll try that. Should be the easiest fix. |
- this should make it use unix escaping on windows
Member
|
@bors: r+ |
Contributor
|
📌 Commit 2e17235 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 6, 2018
Fix the shell_quoting test r? @alexcrichton add-on to #5666 - Added `mod shell_quoting;` to testsuite/main.rs, so it actually runs - fixed bugs in the test
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton
add-on to #5666
mod shell_quoting;to testsuite/main.rs, so it actually runs