Set ARCHFLAGS environment variable - for Perl modules

[mkoeppe]

To make installing Perl modules easier on Mac OS X, we should set the ARCHFLAGS environment variable. This is to make sure that the output of perl -MExtUtils::Embed -e ldopts and perl -MExtUtils::Embed -e ccflags (picked up from system perl) do not contain -arch flags incompatible with our gcc.

This simplifies perl_term_readline_gnu (#20894), polymake (#20892), and makes installing pypolymake (#21170) as a pip package possible.

CC: @videlec @jdemeyer @embray @vbraun @sagetrac-tmonteil @dimpase @kcrisman

Component: build

Author: Matthias Koeppe

Branch: 78f2cfa

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/21175

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-To make installing Perl modules easier on Mac OS X, we should set the ARCHFLAGS environment variable. This is to make sure that the output of "perl -MExtUtils::Embed -e ldopts" and "perl -MExtUtils::Embed -e ccflags" (picked up from system perl) do not contain -arch flags incompatible with our gcc.
+To make installing Perl modules easier on Mac OS X, we should set the ARCHFLAGS environment variable. This is to make sure that the output of `perl -MExtUtils::Embed -e ldopts` and `perl -MExtUtils::Embed -e ccflags` (picked up from system `perl`) do not contain `-arch` flags incompatible with our gcc.
 
 This simplifies `perl_term_readline_gnu` (#20894), `polymake` (#20892), and makes installing `pypolymake` (#21170) as a pip package possible.

[mkoeppe]

Branch: u/mkoeppe/set_archflags_environment_variable___for_perl_modules

[mkoeppe]

Commit: 4c23c4e

[mkoeppe]

New commits:

01abf17	Set ARCHFLAGS on Darwin
4c23c4e	perl_term_readline_gnu: Don't set ARCHFLAGS, use global setting

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Changed commit from 4c23c4e to 4fce479

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

af44810	Merge tag '7.4.beta1' into t/21175/set_archflags_environment_variable___for_perl_modules
4fce479	polymake: Don't set ARCHFLAGS, use global setting

[mkoeppe]

comment:7

Needs review.

[dimpase]

comment:8

It looks OK on Linux; must it be tested on OSX too?

[mkoeppe]

comment:9

I have tested it on both platforms.

[dimpase]

comment:10

put in this, and then tried to install polymake on OSX, and got

[polymake-3.0r2] checking fink installation ... The Fink package system is a mandatory prerequisite to build and use polymake under MacOS.
[polymake-3.0r2] Please refer to http://www.polymake.org/doku.php/mac for details and installation instructions.
[polymake-3.0r2] If you already have Fink installed at a non-standard location, please specify it using option --with-fink
[polymake-3.0r2] Error configuring Polymake

Really? Fink?

[sagetrac-git]

Changed commit from 4fce479 to 78f2cfa

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

78f2cfa

Restore --without-fink that was lost

[mkoeppe]

comment:12

Thanks for catching this -- I killed the --without-fink by accident. Should work now.

[dimpase]

comment:13

OK, looks good now.