Fix release dist workflow #40709
Merged
Fix release dist workflow #40709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 788a0a3; changes) is ready! 🎉 |
dimpase
approved these changes
Aug 28, 2025
5 tasks
This was referenced Sep 17, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 24, 2025
sagemathgh-40843: Restore release notes creation step <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> fixes the issue discussed in https://groups.google.com/g/sage- devel/c/LFfhN0CpGJ8. However, we retain the idea of sagemath#40709 that a github release is made only in one step in the workflow. Previously, before sagemath#40709, a github release was made in two steps "Create release" and "Create release assets". This strategy worked well but started failing some months ago. Test (with sagemath#40840): https://github.com/kwankyu/sage/actions/runs/17846547780. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40843 Reported by: Kwankyu Lee Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2025
sagemathgh-40843: Restore release notes creation step <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> fixes the issue discussed in https://groups.google.com/g/sage- devel/c/LFfhN0CpGJ8. However, we retain the idea of sagemath#40709 that a github release is made only in one step in the workflow. Previously, before sagemath#40709, a github release was made in two steps "Create release" and "Create release assets". This strategy worked well but started failing some months ago. Test (with sagemath#40840): https://github.com/kwankyu/sage/actions/runs/17846547780. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40843 Reported by: Kwankyu Lee Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow fails currently (https://github.com/sagemath/sage/actions/runs/16854260655/job/47745153961) at those two points:
The first is fixed by using the action
softprops/action-gh-releaseto create the release and upload the assets at the same time. The second issue is fixed by disabling wheel building for now (it would be good to investigate wheel building for sagelib).Along the way, removed a few outdated things (like sdist for old sagelib-with-setuptools or wheel building for sage-conf).
📝 Checklist
⌛ Dependencies