VsCode: create local output channel even if tracing is disabled

[abgruszecki]

We should still create a local output channel if remote tracing is disabled, BUT dotty.trace.server is set to be consistent with how other plugins implement the functionality.

I broke the check at the beginning of initializeAsyncWorkspaceDump when I set the default value of workspace dump URL to empty string in package.json. Note that checking if the url is falsey is morally fine, since all falsey strings are invalid (absolute) URLs. This is already done by isTracingEnabled.

[smarter]

We should still create a local output channel if remote tracing is disabled, BUT dotty.trace.server is set to be consistent with how other plugins implement the functionality.

Hmm, so using current master I've tried creating a new project with just:

{
  "dotty": {
    "trace": {
      "server": { "format": "JSON", "verbosity": "verbose" }
    }
  }
}

And I do see lsp logs in "Dotty LSP Communication" in the Output panel.

[abgruszecki]

@smarter I just checked and the channel created is named "Dotty", not "Dotty LSP Communication" - seems like VsCode creates a channel for LSP logging automatically if we don't do it ourselves. It does not seem to me like this is the kind of behaviour we want to rely on - it'd be better to consistently use the channel we created and control ourselves.

[smarter]

Sure.