Skip to content

VsCode: create local output channel even if tracing is disabled #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2018
Merged

VsCode: create local output channel even if tracing is disabled #5368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions vscode-dotty/src/tracer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,15 @@ export class Tracer {

run(): vscode.OutputChannel | undefined {
const consentCommandDisposable = vscode.commands.registerCommand(consentCommandName, () => this.askForTracingConsent())
if (this.isTracingEnabled) {
if (this.tracingConsent.get() === 'no-answer') this.askForTracingConsent()
this.initializeAsyncWorkspaceDump()

const lspOutputChannel = this.createLspOutputChannel()
const statusBarItem = this.createStatusBarItem()
for (const disposable of [consentCommandDisposable, lspOutputChannel, statusBarItem]) {
if (disposable) this.ctx.extensionContext.subscriptions.push(disposable)
}
return lspOutputChannel
if (this.isTracingEnabled && this.tracingConsent.get() === 'no-answer') this.askForTracingConsent()
this.initializeAsyncWorkspaceDump()

const lspOutputChannel = this.createLspOutputChannel()
const statusBarItem = this.createStatusBarItem()
for (const disposable of [consentCommandDisposable, lspOutputChannel, statusBarItem]) {
if (disposable) this.ctx.extensionContext.subscriptions.push(disposable)
}
return lspOutputChannel
}

private askForTracingConsent(): void {
Expand All @@ -111,7 +109,7 @@ export class Tracer {

private initializeAsyncWorkspaceDump() {
const url = this.remoteWorkspaceDumpUrl
if (url === undefined) return
if (!url) return

const doInitialize = () => {
try {
Expand Down