Skip to content

Conversation

@henryiii
Copy link
Member

@scikit-hep scikit-hep deleted a comment from sourcery-ai bot Mar 23, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 23, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 13.11 🙂 13.11 🙂 0.00
Method Length 137.18 😞 137.00 😞 -0.18 👍
Working memory 16.13 ⛔ 16.13 ⛔ 0.00
Quality 38.24% 😞 38.25% 😞 0.01% 👍
Other metrics Before After Change
Lines 410 408 -2
Changed files Quality Before Quality After Quality Change
src/hist/plot.py 38.24% 😞 38.25% 😞 0.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/hist/plot.py plot_pull 21 😞 699 ⛔ 21 ⛔ 18.34% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/hist/plot.py plot2d_full 9 🙂 278 ⛔ 14 😞 38.61% 😞 Try splitting into smaller methods. Extract out complex expressions
src/hist/plot.py _curve_fit_wrapper 5 ⭐ 156 😞 14 😞 50.72% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/hist/plot.py _expr_to_lambda 9 🙂 129 😞 11 😞 54.60% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/hist/plot.py plot_pie 1 ⭐ 51 ⭐ 10 😞 75.33% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@henryiii henryiii merged commit e12f748 into master Mar 23, 2021
@henryiii henryiii deleted the henryiii-patch-1 branch March 23, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant