Skip to content

Conversation

@paulkaplan
Copy link
Contributor

@paulkaplan paulkaplan commented Oct 23, 2018

Resolves

What Github issue does this resolve (please include link)?

Proposed Changes

Describe what this Pull Request does

Make the sprite library, surprise sprite and file upload sprite switch to code tab once the sprite is added. Adds an integration test to make sure it does that. Also check that the "paint a sprite" switches to the costume tab

Reason for Changes

Explain why these changes should be made

Test Coverage

Please show how you have added tests to cover your changes

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

rschamp
rschamp previously approved these changes Oct 23, 2018
Copy link
Contributor

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the integration test!

@paulkaplan
Copy link
Contributor Author

@kchadha I added switching to the code tab on restore because it seems correct and it also fixes #2858

@paulkaplan paulkaplan merged commit db1d5bd into scratchfoundation:develop Oct 23, 2018
@paulkaplan paulkaplan deleted the switch-to-code-after-sprite branch October 23, 2018 20:21
@thisandagain
Copy link
Contributor

Thanks @paulkaplan.

/cc @ntlrsk @kosiecki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a sprite should default to Code tab (as in 2.0) Uploading a sprite without any sounds while the sound tab is visible crashes sound editor

3 participants