DAND-61-Add support for groups #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ockito to avoid pod dependency issue.
…identify and use group in app delegate of example project.
|
By analyzing the blame information on this pull request, we identified and undefined to be a potential reviewer. |
briemcnally
suggested changes
Jan 7, 2020
There was a problem hiding this comment.
Hey @OllaAshour. Requested some changes to ensure we maintain parity with our a.js integration. Let me know if you have any questions or need any further clarification on how to leverage the settings.
briemcnally
suggested changes
Jan 8, 2020
briemcnally
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Associated JIRA Tickets:
https://segmentcontractors.atlassian.net/browse/DAND-61