-
Notifications
You must be signed in to change notification settings - Fork 29
DAND-61-Add support for groups #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
briemcnally
merged 10 commits into
segment-integrations:master
from
OllaAshour:DAND-61-Add-Support-For-Groups
Jan 9, 2020
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f38af13
DAND-61-Update Mixpanel, Analytics versions, use older version of OCM…
OllaAshour f9392c2
DAND-61- Add support for groups with and without names and setOnce tr…
OllaAshour cb02270
DAND-61-Update tests to include groups
OllaAshour 46bf0a8
Add support for example usage of analytics, and mixpanel usage, with …
OllaAshour 472ff7a
DAND-61-Update changelod and update podspec version for release
OllaAshour cba3207
DAND-61- Remove specific write key and add more group properties in t…
OllaAshour e76a94a
DAND-61-Add groupIdentifierTraits settings check and handling. Updat…
OllaAshour fa2c103
DAND-61- Remove check on group name, and set group with identifier va…
OllaAshour 06790df
DAND-61-Update test to verify groupIdentifierTraits
OllaAshour ff9511c
DAND-61-Revert the version update in CHANGELOG and podspec
OllaAshour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,13 +7,30 @@ | |
| // | ||
|
|
||
| #import "SEGAppDelegate.h" | ||
|
|
||
| #import <Analytics/SEGAnalytics.h> | ||
| #import <Segment-Mixpanel/SEGMixpanelIntegrationFactory.h> | ||
|
|
||
| @implementation SEGAppDelegate | ||
|
|
||
| - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions | ||
| { | ||
| // Override point for customization after application launch. | ||
|
|
||
| // Override point for customization after application launch. | ||
| [SEGAnalytics debug:YES]; | ||
| SEGAnalyticsConfiguration *config = [SEGAnalyticsConfiguration configurationWithWriteKey:@"YOUR_WRITE_KEY_HERE"]; | ||
|
|
||
| // Add any of your bundled integrations. | ||
| [config use:[SEGMixpanelIntegrationFactory instance]]; | ||
|
|
||
| [SEGAnalytics setupWithConfiguration:config]; | ||
|
|
||
| [[SEGAnalytics sharedAnalytics] identify:@"segment-fake-tester-Mixpanel" | ||
| traits:@{ @"email": @"[email protected]" }]; | ||
|
|
||
| [[SEGAnalytics sharedAnalytics] group:@"testversion1" traits:@{ @"name": @"test group"}]; | ||
|
|
||
|
|
||
| return YES; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.