Skip to content

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jul 16, 2025

Fixes sillsdev/serval#709

This PR adds support for specifying tags via build_options, for example:

from machine.jobs.build_smt_engine import run
args = {
    'model_type': 'thot',
    'engine_id': '6848db0e6062343fa1d3a472',
    'build_id': '687715134a39e1ae2909b94d',
    'shared_file_uri': 's3://silnlp',
    'shared_file_folder': 'docker-compose/',
    'build_options': '''{"tags":"sf-dev"}''',
    'clearml': True
}
run(args)

The job in ClearML then will display as follows:
image

The build options will be configured in Scripture Forge. No change to Serval is required.


This change is Reviewable

@pmachapman pmachapman requested a review from ddaspit July 16, 2025 03:05
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)


machine/jobs/build_nmt_engine.py line 48 at r1 (raw file):

    try:
        logger.info("NMT Engine Build Job started")
        update_settings(SETTINGS, args, task, logger)

I like this a lot 😁

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)

@pmachapman pmachapman merged commit f785d3c into main Jul 16, 2025
16 checks passed
@pmachapman pmachapman deleted the clearml_tags branch July 16, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tag ClearML jobs in order to differentiate between SF Prod and SF QA jobs

3 participants