Add tags to Serval jobs based on the Scripture Forge environment

[pmachapman]

This PR passes a tag to Serval, based on the Scripture Forge environment, so that the jobs in ClearML are tagged. These tags are only visible in ClearML.

See also: sillsdev/machine.py#208

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (a46eb20) to head (ad7ef24).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...XForge.Scripture/Services/MachineProjectService.cs	97.43%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3316      +/-   ##
==========================================
+ Coverage   82.53%   82.55%   +0.01%     
==========================================
  Files         605      605              
  Lines       35269    35301      +32     
  Branches     5737     5744       +7     
==========================================
+ Hits        29110    29141      +31     
- Misses       5301     5313      +12     
+ Partials      858      847      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[RaymondLuong3]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/Services/MachineProjectService.cs line 2168 at r1 (raw file):

            options["tags"] = tag;
        }
        else if (options["tags"].Type == JTokenType.String && options["tags"].ToString() != tag)

What is the reason that we are supporting multiple tags? I would have expected that each build would really only have one tag.

Code quote:

        else if (options["tags"].Type == JTokenType.String && options["tags"].ToString() != tag)

[pmachapman]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)

---

src/SIL.XForge.Scripture/Services/MachineProjectService.cs line 2168 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

What is the reason that we are supporting multiple tags? I would have expected that each build would really only have one tag.

Mostly because the ClearML API supports it, but also as I think there is a pretty reasonable chance tags could be added in future. I wrote the code to merge the tags in the ServalConfig so that a Serval Admin could configure custom tags in the Serval Config for a project, if they wanted to track special information for a project, such as Catapult, or something else.

[RaymondLuong3]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/Services/MachineProjectService.cs line 2168 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Mostly because the ClearML API supports it, but also as I think there is a pretty reasonable chance tags could be added in future. I wrote the code to merge the tags in the ServalConfig so that a Serval Admin could configure custom tags in the Serval Config for a project, if they wanted to track special information for a project, such as Catapult, or something else.

Ok, that makes sense to me. Thanks for the explanation.