Skip to content

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 12, 2023

Addresses sillsdev/serval#178


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit October 12, 2023 18:27
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


machine/jobs/settings.yaml line 29 at r1 (raw file):

    generate_params:
      num_beams: 1
dummy_build:

What deployment environment is this being used in? I think the deployment environment would be a better name, i.e. "qa".

@johnml1135
Copy link
Collaborator Author

machine/jobs/settings.yaml line 29 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

What deployment environment is this being used in? I think the deployment environment would be a better name, i.e. "qa".

staging.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 7b195cb into main Oct 13, 2023
@ddaspit ddaspit deleted the environment_updates branch October 13, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants