Correct bad LSB MSB math #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "readRegister" to only read one byte, not two Fixed bad LBS MBS combination math in "getXData", "getYData", "getZData" and "getAngelResult"
Changed "readRegister" to only read one byte, not two Fixed bad LSB MSB combination math in "getXData", "getYData", "getZData" and "getAngleResult"
|
Hi Raelx, As for the comment/change in the code for the As for the bitwise math, that has been tested accordingly and will be changed in the latest release of the repo. Thank you for your contributions! |
|
Hi, I am also experiencing the inconsistent readings mentioned in issue #2. This fix helps, but release v1.0.2 doesn't seem to be available on Arduino IDE or PlatformIO. |
|
Hi @ws998116 , thanks for letting us know! I'll check that out now and get that corrected. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit math is not my strong suit but this was not working as it was and after a lot of digging it seems like the math for combining the LSS and MSB bytes in the X/Y/Z/angle functions was bad.
Also it seems that the readRegister function was reading two bytes even though it was always using only the first. Changed this to only read one byte.