Skip to content

Correct bad LSB MSB math #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Correct bad LSB MSB math #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb0e236
Update SparkFun_TMAG5273_Arduino_Library.cpp
Raelx Sep 20, 2023
1436dc5
Update SparkFun_TMAG5273_Arduino_Library.cpp
Raelx Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/SparkFun_TMAG5273_Arduino_Library.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ int8_t TMAG5273::writeRegisters(uint8_t regAddress, uint8_t *dataBuffer, uint8_t
uint8_t TMAG5273::readRegister(uint8_t regAddress)
{
uint8_t regVal = 0;
readRegisters(regAddress, &regVal, 2);
readRegisters(regAddress, &regVal, 1);
return regVal;
}

Expand Down Expand Up @@ -2536,13 +2536,16 @@ float TMAG5273::getTemp()
/// @return X-Channel data conversion results
float TMAG5273::getXData()
{
int8_t xLSB = readRegister(TMAG5273_REG_X_LSB_RESULT);
int8_t xMSB = readRegister(TMAG5273_REG_X_MSB_RESULT);
int8_t xLSB = 0;
int8_t xMSB = 0;

xLSB = readRegister(TMAG5273_REG_X_LSB_RESULT);
xMSB = readRegister(TMAG5273_REG_X_MSB_RESULT);

// Variable to store full X data
int16_t xData = 0;
// Combines the two in one register where the MSB is shifted to the correct location
xData = -(xMSB << 8) | xLSB;
xData = xLSB + (xMSB << 8);

// Reads to see if the range is set to 40mT or 80mT
uint8_t rangeValXY = getXYAxisRange();
Expand Down Expand Up @@ -2577,7 +2580,8 @@ float TMAG5273::getYData()

// Variable to store full Y data
int16_t yData = 0;
yData = -(yMSB << 8) | (yLSB); // Combines the two in one register where the MSB is shifted to the correct location
// Combines the two in one register where the MSB is shifted to the correct location
yData = yLSB + (yMSB << 8);

// Reads to see if the range is set to 40mT or 80mT
uint8_t rangeValXY = getXYAxisRange();
Expand Down Expand Up @@ -2613,7 +2617,7 @@ float TMAG5273::getZData()
// Variable to store full X data
int16_t zData = 0;
// Combines the two in one register where the MSB is shifted to the correct location
zData = -(zMSB << 8) | (zLSB);
zData = zLSB + (zMSB << 8);

// Reads to see if the range is set to 40mT or 80mT
uint8_t rangeValZ = getZAxisRange();
Expand Down Expand Up @@ -2660,7 +2664,7 @@ float TMAG5273::getAngleResult()
float finalVal = 0;

// Combining the register value
angleReg = (angleMSB << 8) | angleLSB;
angleReg = angleLSB + (angleMSB << 8);

// Removing the uneeded bits for the fraction value
decValue = float(angleLSB & 0b1111) / 16;
Expand Down