Skip to content

[fix]: support nil output in RenderTester Publisher extension #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2023
Merged

[fix]: support nil output in RenderTester Publisher extension #236

merged 2 commits into from
Aug 10, 2023

Conversation

@jamieQ
Copy link
Contributor

@jamieQ jamieQ commented Aug 10, 2023 •
edited
Loading

Issue

  • the WorkflowCombine RenderTester extensions didn't allow nil output

Description

  • add a new method to support nil output and match the naming convention of analogous methods
  • deprecate old method
  • update tests

addresses #235

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

jamieQ
jamieQ commented Aug 10, 2023
View reviewed changes
WorkflowCombine/Testing/PublisherTesting.swift
)
}

@available(*, deprecated, renamed: "expect(publisher:producingOutput:key:)")
Copy link
Contributor Author

@jamieQ jamieQ Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a handful of uses in the monorepo that can be migrated to avoid this warning

@jamieQ jamieQ marked this pull request as ready for review August 10, 2023 16:26
@jamieQ jamieQ requested a review from a team as a code owner August 10, 2023 16:26
@jamieQ jamieQ merged commit 082d9f1 into main Aug 10, 2023
@jamieQ jamieQ deleted the jquadri/publisher-render-tester branch August 10, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjohnson12 mjohnson12 mjohnson12 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamieQ @mjohnson12