Skip to content

Conversation

@BenGalewsky
Copy link
Contributor

@BenGalewsky BenGalewsky commented Sep 9, 2024

@BenGalewsky BenGalewsky marked this pull request as draft September 9, 2024 19:45
@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (2dfb069) to head (2d248b1).
Report is 53 commits behind head on 3.0_develop.

Additional details and impacted files
@@               Coverage Diff               @@
##           3.0_develop     #444      +/-   ##
===============================================
+ Coverage        82.02%   82.92%   +0.90%     
===============================================
  Files               26       26              
  Lines             1363     1429      +66     
===============================================
+ Hits              1118     1185      +67     
+ Misses             245      244       -1     
Flag Coverage Δ
unittests 82.92% <100.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BenGalewsky and others added 2 commits September 9, 2024 17:00
added doc_week branch in docs.yml to debug and view documentation
changes on github pages
Readthedocs with pyproject.toml
@ketan96-m
Copy link
Collaborator

As a final step to merge to 3.0_develop, removing the doc_week entry from the docs.yml file.

@ketan96-m ketan96-m marked this pull request as ready for review September 18, 2024 14:15
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are formatting errors found quickly passing through that are in the changes made. There are others in the docs that aren't in files touch yet, so those should also get fixed.

gordonwatts and others added 3 commits September 18, 2024 08:20
* First go at a very simple xAOD example

* Fix up to use a opendata file for the example.

* Remove logging

* Working example for simple func_adl

* Minor updates to spelling corrections

* Add a typed example

* Fix up the naming of the typed call

* Add the examles to `examples1.rst`

* Fix up example to properly reference everything!
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Resolves #446 syntax in the body (currently blank) of this PR to close out the issue once this is merged. (#446 (comment))

As a follow up to this, and something that @ponyisi raised on Slack, in the 3.0_develop branch README (https://github.com/ssl-hep/ServiceX_frontend/blob/55d44f08eaae713747b25dcfca3f4910e731762a/README.md) there is no link to any docs in the README.

Please add a link to the ReadTheDocs (https://servicex-frontend.readthedocs.io/) — and maybe also to the dev docs on GitHub pages (https://ssl-hep.github.io/ServiceX_frontend/) — and make the ReadTheDocs versioned and point to stable by default (not latest).

@kyungeonchoi kyungeonchoi merged commit 6a8d62e into 3.0_develop Sep 18, 2024
36 checks passed
@kyungeonchoi kyungeonchoi deleted the doc_week branch September 18, 2024 20:56
@matthewfeickert
Copy link
Member

Just for future reference (doesn't matter here), putting text in front of Resolves #XXX breaks the operations. So it needs to literally be just

* Resolves #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants