Skip to content

Add pre-commit to developer extras [DROPS PYTHON 3.8 SUPPORT] #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Add pre-commit to developer extras [DROPS PYTHON 3.8 SUPPORT] #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d0d449
Add pre-commit to developer extras
ponyisi Dec 5, 2024
214365a
Drop Python 3.8 test
ponyisi Dec 5, 2024
c79abc3
Officially require Python >=3.9
ponyisi Dec 5, 2024
736f56d
Remove Python 3.8 code branch
ponyisi Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
matrix:
platform: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
runs-on: ${{ matrix.platform }}

steps:
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version = "3.0.1-alpha.1"
description = "Python SDK and CLI Client for ServiceX"
readme = "README.md"
license = { text = "BSD-3-Clause" } # SPDX short identifier
requires-python = ">=3.8"
requires-python = ">=3.9"
authors = [
{ name = "Ben Galewsky", email = "[email protected]" },
{ name = "Gordon Watts", email = "[email protected]" },
Expand Down Expand Up @@ -80,6 +80,7 @@ test = [
"asyncmock>=0.4.2",
"pandas>=2.0.2",
"pyarrow>=12.0.0",
"pre-commit>=4.0.1",
]
docs = [
"sphinx>=7.0.1",
Expand Down
6 changes: 1 addition & 5 deletions servicex/query_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,7 @@ def transform_complete(task: Task):
)
self.cache.delete_record_by_request_id(self.request_id)
if download_files_task:
import sys
if sys.version_info < (3, 9):
download_files_task.cancel()
else:
download_files_task.cancel("Transform failed")
download_files_task.cancel("Transform failed")
raise task.exception()

if self.current_status.status in DONE_STATUS:
Expand Down
Loading