-
Notifications
You must be signed in to change notification settings - Fork 713
[Clarity-4] add to-ascii?
#6436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This has gotten too ugly. When #6403 merges, I will rebase this and re-open. |
This new builtin function is added as part of Clarity 4, with epoch 3.3. Closes stacks-network#6397 See stacksgov/sips/stacks-network#218
f98f5b4 to
3b74c8a
Compare
|
Fixed merge conflict in changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one nit about being a little more DRY but i'm happy to merge
4747f97
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (74.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6436 +/- ##
============================================
+ Coverage 57.35% 74.59% +17.24%
============================================
Files 558 559 +1
Lines 343239 343602 +363
============================================
+ Hits 196873 256326 +59453
+ Misses 146366 87276 -59090
... and 394 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Builds off of #6403 (should review after that one is merged), adding
to-ascii?support.Applicable issues
to-ascii?#6397Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo