Scale strelka backends to 2 by default #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - net | ||
| volumes: | ||
| - ./configs/backend/:/etc/strelka/:ro | ||
| container_name: sublime_strelka_backend_1 |
There was a problem hiding this comment.
What will our container names be now? #70 I think we'd prefer to ensure they're prefixed, but it's not a huge deal for these ones.
There was a problem hiding this comment.
Good Q. Just goes from _X to -X
I'll see if I can change the prefix so it's more hostname friendly, but I believe that we're okay with the - for these ones since nothing needs to know the name?
There was a problem hiding this comment.
oh wait nevermind, - is better for hostnames than _ anyway
cameron-dunn-sublime
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL docker-compose can automatically scale, so we can specify in the compose file how many to create. To scale it further:
docker-compose up -d --scale sublime_strelka_backend=4We can also consider adding bora scalers this way. Naturally, AWS will do all of this better, but this will mean more mileage and flexibility for Docker deployments.