Skip to content

Scale strelka backends to 2 by default #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023
Merged

Scale strelka backends to 2 by default #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,10 @@ services:
volumes:
- ./configs/frontend/:/etc/strelka/:ro
- logs:/var/log/strelka/
container_name: sublime_strelka_frontend_1
depends_on:
- sublime_strelka_coordinator
deploy:
replicas: 1
sublime_strelka_backend:
image: sublimesec/strelka-backend:0.3
restart: unless-stopped
Expand All @@ -105,9 +106,10 @@ services:
- net
volumes:
- ./configs/backend/:/etc/strelka/:ro
container_name: sublime_strelka_backend_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will our container names be now? #70 I think we'd prefer to ensure they're prefixed, but it's not a huge deal for these ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Q. Just goes from _X to -X
image

I'll see if I can change the prefix so it's more hostname friendly, but I believe that we're okay with the - for these ones since nothing needs to know the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait nevermind, - is better for hostnames than _ anyway

depends_on:
- sublime_strelka_coordinator
deploy:
replicas: 2
sublime_strelka_manager:
image: sublimesec/strelka-manager:0.3
restart: unless-stopped
Expand Down