-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: fix flaky download test #12488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| expect(await page.innerHTML('pre')).toBe('0 false undefined'); | ||
| await page.goto(pathname); | ||
|
|
||
| const download = page.waitForEvent('download', { timeout: 3000 }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to override the default timeout here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember if I added that because it was too short or too long. Let me try removing it.
Let's see if waiting for the download event makes it less flaky.
EDIT: seems less flaky? will try re-running the CI a couple of times. Seems to only error on other flaky tests.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits