Skip to content

chore: fix flaky download test #12488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2024
Merged

chore: fix flaky download test #12488

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f49ac66
wait for download event
teemingc Jul 22, 2024
8367a59
reuse url
teemingc Jul 22, 2024
73ada90
remove timeout override
teemingc Jul 23, 2024
13ec207
use clicknav util
teemingc Jul 23, 2024
3f38a45
oops we don't want to wait for nav when clicking download
teemingc Jul 23, 2024
896c37c
beforeNavigate prevents navigation so don't use clicknav
teemingc Jul 23, 2024
139a318
try page.waitForUrl
teemingc Jul 23, 2024
b2bdc84
apply Ben's suggestions
teemingc Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/kit/test/apps/basics/test/cross-platform/client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,16 +220,18 @@ test.describe('Navigation lifecycle functions', () => {
expect(await page.innerHTML('pre')).toBe('2 false goto');
});

test('beforeNavigate is triggered after clicking a download link', async ({ page, baseURL }) => {
test('beforeNavigate is triggered after clicking a download link', async ({ page }) => {
await page.goto('/navigation-lifecycle/before-navigate/prevent-navigation');

await page.click('a[download]');
expect(await page.innerHTML('pre')).toBe('0 false undefined');
const download = page.waitForEvent('download');
await page.locator('a[download]').click();
await (await download).cancel();

await page.click('a[href="/navigation-lifecycle/before-navigate/a"]');
await expect(page.locator('pre')).toHaveText('0 false undefined');

expect(page.url()).toBe(baseURL + '/navigation-lifecycle/before-navigate/prevent-navigation');
expect(await page.innerHTML('pre')).toBe('1 false link');
await page.locator('a[href="/navigation-lifecycle/before-navigate/a"]').click();

await expect(page.locator('pre')).toHaveText('1 false link');
});

test('afterNavigate calls callback', async ({ page, clicknav }) => {
Expand Down