Skip to content

Conversation

@paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Jul 31, 2024

Alternative to #12484 after the work in sveltejs/svelte#12608

This will double the warnings in versions of svelte 5 before 5.0.0-next.204 but it should clear them after that. Once again at least locally i see some test fails that seems to be completely unrelated. Let's wait for the release of 204 before merging this obviously.

For the moment i've left the test there but maybe we should remove it since in older versions it will actually throw more warnings?

EDIT: just tested it locally and i realized you are not doubling the warning since the svelte ignore warning is at compile time


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

paoloricciuti and others added 10 commits July 21, 2024 00:03
* feat: Generate static _routes in Cloudflare adapter

* Update .changeset/ten-shirts-add.md

* fix: add comements and newline in generated _redirects file

* fix: exclude redirect paths from cloudflare

* fix: check if there are redirects before writing

* Fix formatting

---------

Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 7a280a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti changed the title Ignore warning binding non reactive fix: ignore warning binding non reactive Jul 31, 2024
@dummdidumm dummdidumm merged commit 32220ef into sveltejs:main Aug 1, 2024
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants