Migrate CI to github actions [INFRA-351]

[notoriaga]

For the most part this tries to be a straight port of what travis did, with a few exceptions -

• CI is run on a per-language basis. Tags and pushes to master will trigger everything. You can also manually trigger any of the workflows from the Actions tab.
• All release artifacts have a .zip extension (previously a mix of .zip and .tar.gz)

This also includes a few miscellaneous changes to get everything working -

• Bumps serialport in the js library
• Fixes test-javascript make recipe
• Benchmark threshold tweaks

[notoriaga]

Test release - https://github.com/swift-nav/libsbp/releases/tag/v0.0.0-test

[silverjam]

@notoriaga I'm only seeing the Rust workflows running, is there something we need to do to enable the other workflows?

[notoriaga]

@notoriaga I'm only seeing the Rust workflows running, is there something we need to do to enable the other workflows?

I was trying out using these as triggers for each language -

on:
  push:
    tags:
      - "*"
  pull_request:
    paths:
      - "$lang/**"

So the language specific workflows only run on prs that change that folder. I removed the travis badge from the Cargo.toml which is why it's building rust. This is obviously not how travis is doing it now, but figured it might be nice to save minutes. It runs everything on tags just to be sure. If we wanna run everything on all prs we just need to remove the paths: directive

[silverjam]

@notoriaga I'm only seeing the Rust workflows running, is there something we need to do to enable the other workflows?

I was trying out using these as triggers for each language -

on:
  push:
    tags:
      - "*"
  pull_request:
    paths:
      - "$lang/**"

So the language specific workflows only run on prs that change that folder. I removed the travis badge from the Cargo.toml which is why it's building rust. This is obviously not how travis is doing it now, but figured it might be nice to save minutes. It runs everything on tags just to be sure. If we wanna run everything on all prs we just need to remove the paths: directive

Ok, this makes sense, I think it'd also make sense to have a way to force everything to build, (which would be nice for this PR in particular, so we can see everything running).

[silverjam]

@notoriaga untagged myself for now, please re-tag me when there's new things to review

[notoriaga]

@silverjam A few updates/questions

• Removed the custom actions
• Added workflow_dispatch as an event to all the workflows. This lets you trigger them manually. The option doesn't show until you have the workflows on the default branch for some reason. after you do though you can run the workflow on any branch
• I changed all the artifacts to .zip to be consistent with how we've been doing it elsewhere. A little worried this might break something, not sure if we have any automation around these release

[silverjam]

@silverjam A few updates/questions

* Removed the custom actions

* Added `workflow_dispatch` as an event to all the workflows. This lets you trigger them manually. The option doesn't show until you have the workflows on the default branch for some reason. after you do though you can run the workflow on any branch

👍

* I changed all the artifacts to `.zip` to be consistent with how we've been doing it elsewhere. A little worried this might break something, not sure if we have any automation around these release

I don't think this will break anything

[silverjam]

@notoriaga is this ready for review again?

[notoriaga]

@silverjam Yeah should be ready for a look. Only thing I can't figure out is why the rust versions seem to run slower on gh actions compared to travis

Occasionally the benchmarks pass, so wondering if it has to do with gh actions running on shared instances. But I thought that was one of the reasons the benchmarks use docker, for more consistent resource availability across runs

[jayvdb]

IIRC, the bash codecov usually doesnt set an exit status, so the || .. here is useless.

This upload isnt working; see https://github.com/swift-nav/libsbp/runs/2124966802#step:5:530

It seems codecov hasnt been working for a while in this repo, so perhaps that could be another task to get them all working in github actions after this PR.

[jayvdb]

It seems codecov<->github-integration isnt enabled for this repo. It is possible to send reports without that integration being enabled.

[jayvdb]

there are three jvms on https://github.com/actions/virtual-environments/blob/ubuntu18/20210309.1/images/linux/Ubuntu1804-README.md . It would be useful to print the JVM version that is being used for these tests. (Under Travis, the version was explicitly being set to 1.8.0)

[jayvdb]

Likely all workflows should run if test_data/** is modified

[silverjam]

So we can probably add this back later, but it would be for all languages, instead of just one global "CI" badge?

[jayvdb]

the important comments are resolved

[silverjam]

@notoriaga let's fix-up the PR message to include some more details and please tag the summary with a Jira and then...

[notoriaga]

please tag the summary with a Jira and then...

@silverjam do you mean by adding the ticket to the pr name?

[silverjam]

please tag the summary with a Jira and then...

@silverjam do you mean by adding the ticket to the pr name?

Yes