Skip to content

Conversation

@IsakTjernberg
Copy link
Contributor

Background

New versions of the Linux resource usage messages, with the addition of timestamps.
See section in design doc.
Also fixes a typo in a previously existing message.

The changes are split into two commits for easier review, the first one is for updating the YAML spec and the second commit holds all the changes as automatically generated by the make step. Will squash them on merge.

Copy link
Contributor

@dgburr dgburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the old (non-timestamped) messages be marked as deprecated?

@silverjam
Copy link
Contributor

Should the old (non-timestamped) messages be marked as deprecated?

Changes look good, and yes, we should follow the existing convention of renaming the old messages to _DEP_A and have the new messages take the name of the old messages.

FYI, if the Rust build fails, the workaround is to clear the caches on Travis. Hopefully this issue will be gone once we merge #905 (cc @notoriaga).

@IsakTjernberg IsakTjernberg force-pushed the isak/timestamped-resource-msgs branch from c9e6ae9 to 4fe5640 Compare February 26, 2021 21:12
@IsakTjernberg
Copy link
Contributor Author

Alright, I made the old ids deprecated and re-used their names for the new messages.
@silverjam How do I clear the cache on Travis? Do I need to be signed in there to see that option somewhere? I haven't authorized Travis with my Github account and don't know if I should.

@silverjam
Copy link
Contributor

Alright, I made the old ids deprecated and re-used their names for the new messages.
@silverjam How do I clear the cache on Travis? Do I need to be signed in there to see that option somewhere? I haven't authorized Travis with my Github account and don't know if I should.

It's fine to authorize your account with Travis, it's still used for quite a few things (even though we're trying to phase it out). Once you log in the cache control is pretty easy to find:

Then:

Screenshot 2021-02-26 163702

@IsakTjernberg IsakTjernberg merged commit f2a1804 into master Feb 28, 2021
@IsakTjernberg IsakTjernberg deleted the isak/timestamped-resource-msgs branch February 28, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants