Skip to content

Conversation

adrian-kong
Copy link
Contributor

@adrian-kong adrian-kong commented May 9, 2023

@adrian-kong adrian-kong requested a review from silverjam May 9, 2023 10:26
@silverjam
Copy link
Contributor

Do we need the Cargo.lock changes?

@adrian-kong
Copy link
Contributor Author

adrian-kong commented May 9, 2023

Do we need the Cargo.lock changes?

maybe not but since the main issue is sysinfo/ntapi not being updated maybe just keep,

what other fixes did we need to port?

@silverjam
Copy link
Contributor

Should this be merged into this branch? https://github.com/swift-nav/swift-toolbox/tree/swift-toolbox-v4.0.0-branch

@adrian-kong
Copy link
Contributor Author

Should this be merged into this branch? https://github.com/swift-nav/swift-toolbox/tree/swift-toolbox-v4.0.0-branch

both branches are identical
oh didn't realize there already is a branch for that. 👍

@adrian-kong adrian-kong changed the base branch from adrian/prev_release to swift-toolbox-v4.0.0-branch May 10, 2023 05:43
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there are changes to the CI repo that we'll need too? Do we need to branch the CI repo?

@adrian-kong
Copy link
Contributor Author

Assuming there are changes to the CI repo that we'll need too? Do we need to branch the CI repo?

yep we do, currently here:
https://github.com/swift-nav/swift-toolbox-ci/pull/11

there are some issues with mac signing which looks odd 🤔
https://github.com/swift-nav/swift-toolbox-ci/actions/runs/4933517260/jobs/8818076340
other than that it seems like it would release just fine

@adrian-kong adrian-kong requested a review from silverjam May 10, 2023 23:51
@adrian-kong
Copy link
Contributor Author

adrian-kong commented May 10, 2023

https://github.com/swift-nav/swift-toolbox/releases/tag/v4.1.11
release was successful after retry

will need to merge this in to fix #1035 ci
@silverjam

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@adrian-kong adrian-kong requested a review from a team May 10, 2023 23:53
@silverjam silverjam closed this May 11, 2023
@silverjam silverjam reopened this May 11, 2023
@silverjam
Copy link
Contributor

oops, didn't mean to close the PR

Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge once we're able to get CI passing cleanly

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@silverjam
Copy link
Contributor

silverjam commented May 11, 2023

Decoupled CI is working, just taking a bit longer, I think we adjust the timeout to 45 minutes it should pass cleanly: https://github.com/swift-nav/swift-toolbox-ci/actions/runs/4942658545

image

@adrian-kong adrian-kong enabled auto-merge (squash) May 11, 2023 01:50
@adrian-kong adrian-kong merged commit d060b3b into swift-toolbox-v4.0.0-branch May 11, 2023
@adrian-kong adrian-kong deleted the adrian/port_to_v4.0.13 branch May 11, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants