Skip to content

Conversation

adrian-kong
Copy link
Contributor

@adrian-kong adrian-kong commented May 10, 2023

  • adds additional ntrip subtab to advanced tab
  • adds--enable-ntrip flag, safe to merge since this feature is off by default
  • static option (manual input) and dynamic (auto lat lon alt values)
  • output options, RTCM or SBP out
  • bundles rtcm3tosbp binary under /binaries/{OS}/rtcm3tosbp(.exe)
  • adds additional hidden until running status bar to capture amount of bytes
image image

@adrian-kong adrian-kong requested a review from silverjam May 10, 2023 05:25
@adrian-kong
Copy link
Contributor Author

with regards to the options that we want to parse, is it something like...

general textfields that we must have:
URL, USERNAME, PASSWORD

  • radio button, [GGA/CRA]
if GGA:
  add LAT, LON, ALT textfields
elif CRA:
  add REQ_COUNTER, AREA_ID, CORR_MASK, SOLN_ID text fields

i.e. main fields we want / capnproto struct is:

struct NtripConfig {
    url, username, password,
    (if gga then fill in...) lat, lon, alt
    (if cra then fill in...) req_counter, area_id, corr_mask, soln_id
}

add connect and disconnect button

on connect basically run main function from https://github.com/swift-nav/ntripping/blob/master/src/main.rs#L277 (maybe we should turn this into lib to reuse?)
on disconnect basically kills the thread ran in main.

  • add some additional capnproto packets to send byte info, error log, ntrip config etc...

also havent touched ntrip before... didnt really understand what we wanted to do with the emitting output from ntripping.

@silverjam

@silverjam
Copy link
Contributor

  • radio button, [GGA/CRA]

Information for build GGA should come from two sources:

  • Static, entered by the user
  • Dynamic, from the lat/lon position emitted by the device

We don't need CRA for this feature.

@silverjam
Copy link
Contributor

on connect basically run main function from https://github.com/swift-nav/ntripping/blob/master/src/main.rs#L277 (maybe we should turn this into lib to reuse?)

Could be useful eventually but I don't think we should pursue right now, let's see what's common between the two implementations before we make a decision to create a common library.

@silverjam
Copy link
Contributor

also havent touched ntrip before... didnt really understand what we wanted to do with the emitting output from ntripping.

Ntrip is a protocol Skylark uses for delivering corrections to the device, the location of the device is sent to the server so that it can either: (1) fetch region specific error correction information; (2) model a virtual base station in order to provide error correction. Data from Ntrip needs to be routed to the device in order for it to correct it's position.

Base automatically changed from adrian/port_to_v4.0.13 to swift-toolbox-v4.0.0-branch May 11, 2023 01:51
@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@silverjam silverjam changed the title add ntrip client add ntrip client [CPP-944] Jun 19, 2023
@silverjam silverjam changed the title add ntrip client [CPP-944] Add ntrip client [CPP-944] Jun 19, 2023
@adrian-kong adrian-kong requested review from silverjam, pcrumley and a team June 23, 2023 00:13
@silverjam silverjam changed the title Add ntrip client [CPP-944] Add ntrip client [v4.0] [CPP-944] Jun 23, 2023
Copy link
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... however do you need to port the unrelated bugfixes in resources/SettingsTabComponents/SettingsPane.qml file in the other PR to this one? or were those bugs introduced after v4.0

@silverjam
Copy link
Contributor

silverjam commented Jun 26, 2023

Agree with @pcrumley -- let's make sure we don't miss anything from https://github.com/swift-nav/swift-toolbox/pull/1088/files#diff-426f1e106c29afd7217275dd47a806603df0770a48d007397e430ee887fc1949 (if these changes are needed on this branch).

@adrian-kong
Copy link
Contributor Author

adrian-kong commented Jun 26, 2023

the changes for parents -> parent seem to be a typo causing ReferenceError (introduced later)
the changes for height seems to be an issue on both branches - settings pane cutting off or scroll bar doesn't adjust to the amount of content on page (will revert this unrelated changes (doesn't seem to fix the issue) for both branches and logged a ticket: https://swift-nav.atlassian.net/browse/CPP-953 if this ever becomes an issue again)

@adrian-kong adrian-kong enabled auto-merge (squash) June 26, 2023 21:54
@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@adrian-kong adrian-kong merged commit b376003 into swift-toolbox-v4.0.0-branch Jun 26, 2023
@adrian-kong adrian-kong deleted the adrian/ntrip_client branch June 26, 2023 22:45
adrian-kong added a commit that referenced this pull request Jun 26, 2023
Ports NTRIP client support to the main branch:
#1033
@adrian-kong
Copy link
Contributor Author

moved to SCD board https://swift-nav.atlassian.net/browse/SCD-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants