-
Notifications
You must be signed in to change notification settings - Fork 2
Add ntrip client [v4.0] [CPP-944] #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ntrip client [v4.0] [CPP-944] #1033
Conversation
with regards to the options that we want to parse, is it something like... general textfields that we must have:
i.e. main fields we want / capnproto struct is:
add connect and disconnect button on connect basically run main function from https://github.com/swift-nav/ntripping/blob/master/src/main.rs#L277 (maybe we should turn this into lib to reuse?)
also havent touched ntrip before... didnt really understand what we wanted to do with the emitting output from ntripping. |
Information for build GGA should come from two sources:
We don't need CRA for this feature. |
Could be useful eventually but I don't think we should pursue right now, let's see what's common between the two implementations before we make a decision to create a common library. |
Ntrip is a protocol Skylark uses for delivering corrections to the device, the location of the device is sent to the server so that it can either: (1) fetch region specific error correction information; (2) model a virtual base station in order to provide error correction. Data from Ntrip needs to be routed to the device in order for it to correct it's position. |
Frontend and Release Workflow Started here |
Frontend and Release Workflow Started here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... however do you need to port the unrelated bugfixes in resources/SettingsTabComponents/SettingsPane.qml file in the other PR to this one? or were those bugs introduced after v4.0
Agree with @pcrumley -- let's make sure we don't miss anything from https://github.com/swift-nav/swift-toolbox/pull/1088/files#diff-426f1e106c29afd7217275dd47a806603df0770a48d007397e430ee887fc1949 (if these changes are needed on this branch). |
the changes for |
Frontend and Release Workflow Started here |
Ports NTRIP client support to the main branch: #1033
moved to SCD board https://swift-nav.atlassian.net/browse/SCD-3 |
--enable-ntrip
flag, safe to merge since this feature is off by default/binaries/{OS}/rtcm3tosbp(.exe)