-
Notifications
You must be signed in to change notification settings - Fork 2
[CPP-62][CPP-69]Frontend Benchmark CPU Usage - Windows self hosted runner. #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e6ba62
to
ca665c8
Compare
ca665c8
to
1761811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - silly question though, if this is running in the VM on your laptop... should we wait to setup the self-hosted runner in the lab before merging? Or merge but make passing optional?
Very good point. I added a continue-on-error to the job as well as a timeout. I also turned off the runner in my VM to see the behavior in CI. Interestingly enough it seems that when the runner was not available the CI just waits until one becomes available; however, I think it would fail after the default timeout of 360min. This is actually why I added the timeout as I think it will just wait if no runner is online. UPDATE It appears GA just indefinitely waits for a self hosted runner to become available. Seeing as how this does not incur a charge AFAIK and this is at the end of all stages this should be okay until we set up a more permanent solution? @silverjam |
9370201
to
c4883b6
Compare
Should be fine for now, let's try to get this resolved this week though. |
.github/workflows/main.yml
Outdated
frontend_bench: | ||
name: Run Frontend Benchmarks | ||
continue-on-error: true | ||
timeout-minutes: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2 minutes a realistic timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The benchmark runs in under a minute now. We can increase it as we add more benchmarks.
339151e
to
7f0ea7b
Compare
Details
Self Hosted Runner Setup
Currently tested only on Windows.
Assumes the host has these dependencies preinstalled:
Before attempting to run the benchmark an "rm -rf" is performed on the working folder to remove any trace from previous runs.