Skip to content

Settings write failure popup, add scrolling w/ up+down arrows[CPP-486][CPP-478] #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2022
Merged

Settings write failure popup, add scrolling w/ up+down arrows[CPP-486][CPP-478] #317

merged 3 commits into from
Jan 4, 2022

Conversation

john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented Dec 31, 2021 •
edited
Loading

  • Add popup notification when a settings write failure occurs.
  • Add ability to scroll up and down settings with arrow keys, skips categories, wraps around top/bottom, scrollbar follows up/down motion, if settings tab currently has nothing selected then select first row in table.
  • Fix minor bug which was causing a write to be triggered twice. Now onEditingFinished only occurs if onTextChanged timer is still running.

@john-michaelburke john-michaelburke changed the title Add popup on settings write failure, add scrolling settings arrow up/down[CPP-486][CPP-478] Settings write failure popup, add scrolling w/ up+down arrows[CPP-486][CPP-478] Dec 31, 2021
@john-michaelburke john-michaelburke marked this pull request as ready for review December 31, 2021 01:22
@john-michaelburke john-michaelburke force-pushed the john-michaelburke/CPP-478 branch from 1b8b80f to d6b0e47 Compare January 4, 2022 18:33
@john-michaelburke john-michaelburke merged commit e6271f1 into main Jan 4, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/CPP-478 branch January 4, 2022 19:18
@silverjam silverjam mentioned this pull request Mar 22, 2022
Merged
@silverjam silverjam mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@john-michaelburke @silverjam