Run uninstaller for old windows swift console.[CPP-690] #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
force-pushed
the
john-michaelburke/delete-old-app
branch
from
07bb987 to
5696593
Compare
samvrlewis
reviewed
Mar 27, 2022
|
|
||
| !macro Uninstall Prefix | ||
| Function ${Prefix}Uninstall | ||
| ExecShell open "${old_uninstaller}" "/AllUsers /S" |
There was a problem hiding this comment.
What happens here if the user doesn't have the old console installed?
There was a problem hiding this comment.
It does nothing and continues with the uninstaller.
samvrlewis
approved these changes
Mar 28, 2022
john-michaelburke
force-pushed
the
john-michaelburke/delete-old-app
branch
from
2999b20 to
9402a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to garner full app acceptance 101 😹