Skip to content

Run uninstaller for old windows swift console.[CPP-690] #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Run uninstaller for old windows swift console.[CPP-690] #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions installers/Windows/Installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Unicode true
!define outfile_prefix "swift-console"
!define installer_dir "py39-dist"
!define company_name "Swift Navigation"
!define old_uninstaller "$PROGRAMFILES\${company_name}\${app_name}\Uninstall.exe"

!define vc_redist_url "https://aka.ms/vs/17/release/vc_redist.x64.exe"

Expand Down Expand Up @@ -212,6 +213,7 @@ FunctionEnd

!macro Uninstall Prefix
Function ${Prefix}Uninstall
ExecShell open "${old_uninstaller}" "/AllUsers /S"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens here if the user doesn't have the old console installed?

Copy link
Collaborator Author

@john-michaelburke john-michaelburke Mar 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does nothing and continues with the uninstaller.

RMDir /r "$InstDir"
Delete "$DESKTOP\${app_name}.lnk"
Delete "$SMPROGRAMS\${app_name}.lnk"
Expand Down