Skip to content

bug rollup: legend appearance, recording size, supress splash screen when display CLI help [CPP-754][CPP-758][CPP-737] #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2022
Merged

bug rollup: legend appearance, recording size, supress splash screen when display CLI help [CPP-754][CPP-758][CPP-737] #565

merged 5 commits into from
May 21, 2022

Conversation

@john-michaelburke
Copy link
Collaborator

@john-michaelburke john-michaelburke commented May 20, 2022 •
edited
Loading

  • Added the fix recommended by @keithel-qt which I have confirmed gets rid of the debug message he had added to catch the issue.
  • Converted the + in the legends to circles for Baseline / Solution plots.
  • Fixes incorrect default value for recording size. When the value is non-zero we use kb/mb/gb, default was 0.0MiB.
  • Added logic to prevent the splash screen from showing whenever the cli displays help.
    NOTE: These images dont show the corrected MiB -> MB, took them before adding the fix.

Screen Shot 2022-05-20 at 10 40 38 AM

Screen Shot 2022-05-20 at 10 40 28 AM

@john-michaelburke john-michaelburke requested a review from a team May 20, 2022 18:21
@john-michaelburke john-michaelburke changed the title Few small fixes[CPP-754][CPP-758] Few small fixes[CPP-754][CPP-758][CPP-737] May 20, 2022
notoriaga
notoriaga reviewed May 20, 2022
View reviewed changes
resources/LoggingBar.qml
recordingSize.text = bytesToString(recSize);
else
recordingSize.text = "0.00 MiB";
recordingSize.text = "0.00 MB";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MiB and MB are slightly different right? are we currently recording MBs and this is fixing the label?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see this is just for the 0 bytes recorded case. either way looking at bytesToString const k = 1024 should probably be 1000 if we want MBs not MiBs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was just mislabelled, our calculation is converting to KB/MB/GB/etc:

swift-toolbox/resources/LoggingBar.qml

Line 247 in fe8d553

const k = 1024;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so I think it should be 1000 (https://en.wikipedia.org/wiki/Megabyte table on the left is without the "i"s and it's powers of 10 not 2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if the old console is doing 1024 and showing MBs maybe it's best just to forget about it hahaha

Copy link
Contributor

@silverjam silverjam May 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, technically MiB is supposed to be 1024 and MB is supposed to be 1000-- but in common usage MB can mean 1024 or 1000 depending on context and the apps team's argument was that most "end users" are not going to know what MiB is and in our context, we want to use 1024, not 1000...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh makes sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came here to say that MB is powers of 10 and MiB is powers of 2, as @silverjam mentioned.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like powers of 2 were used in the old console but with the naming convention of KB/MB. So I'll just keep it as is then.

Copy link
Contributor

@silverjam silverjam May 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://devblogs.microsoft.com/oldnewthing/20090611-00/?p=17933

https://answers.microsoft.com/en-us/windows/forum/all/microsoft-to-clear-kib-vs-kb-etc-confusion-anytime/815f5e8f-510f-4bef-9f6c-26d723fe4eeb

I suppose when Windows finally conforms to the standard, then we should too.

silverjam
silverjam approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just needs a fixup for --version and -V

resources/LoggingBar.qml
recordingSize.text = bytesToString(recSize);
else
recordingSize.text = "0.00 MiB";
recordingSize.text = "0.00 MB";
Copy link
Contributor

@silverjam silverjam May 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, technically MiB is supposed to be 1024 and MB is supposed to be 1000-- but in common usage MB can mean 1024 or 1000 depending on context and the apps team's argument was that most "end users" are not going to know what MiB is and in our context, we want to use 1024, not 1000...

@john-michaelburke john-michaelburke force-pushed the john-michaelburke/small-fixes2 branch from 29db7fa to bc7a2fc Compare May 21, 2022 00:29
@john-michaelburke john-michaelburke enabled auto-merge (squash) May 21, 2022 00:33
@john-michaelburke john-michaelburke enabled auto-merge (squash) May 21, 2022 00:57
@john-michaelburke john-michaelburke merged commit bc563e1 into main May 21, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/small-fixes2 branch May 21, 2022 01:37
@silverjam silverjam mentioned this pull request May 31, 2022
Merged
@silverjam silverjam changed the title Few small fixes[CPP-754][CPP-758][CPP-737] bug rollup: legend appearance, recording size, suprocess splash screen when display CLI help [CPP-754][CPP-758][CPP-737] Jun 4, 2022
@silverjam silverjam changed the title bug rollup: legend appearance, recording size, suprocess splash screen when display CLI help [CPP-754][CPP-758][CPP-737] bug rollup: legend appearance, recording size, supress splash screen when display CLI help [CPP-754][CPP-758][CPP-737] Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notoriaga notoriaga notoriaga approved these changes

+2 more reviewers

@silverjam silverjam silverjam approved these changes

@keithel-qt keithel-qt keithel-qt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@john-michaelburke @silverjam @notoriaga @keithel-qt