Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented Jul 14, 2022

Allows the console to be closed after being launched from the command line.


Previous behavior:
cli-console-launch-old


New behavior:
cli-console-launch

@silverjam silverjam changed the title Disable attach_console unless indicated Disable attach_console unless indicated [CPP-792] Jul 14, 2022
@silverjam silverjam marked this pull request as draft July 14, 2022 21:50
@silverjam silverjam marked this pull request as ready for review July 17, 2022 20:26
Copy link
Collaborator

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@silverjam silverjam merged commit 4762113 into main Jul 18, 2022
@silverjam silverjam deleted the silverjam/disable-attach-console branch July 18, 2022 18:40
silverjam pushed a commit that referenced this pull request Aug 1, 2022
* Disable attach_console unless indicated

* disable attach_console in server code too...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants