Disable attach_console unless indicated [CPP-792] [v4.0] #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable attach_console unless indicated * disable attach_console in server code too...
silverjam
changed the title
|
@john-michaelburke this PR shows a SWIFTNAV_CONSOLE_DEBUG that we can re-use for the debug env dump too |
john-michaelburke
approved these changes
Aug 1, 2022
|
Should we merge this to main first? |
It's already on main, I forgot to backport it |
|
Might need to backport this commit as well: |
silverjam
deleted the
silverjam/cherry-pick/47621130637ffd972c334e0c296034b16d0d8ff0
branch
I eventually got to pass by retrying enough time... for future backports I cherry-picked this commit directly and pushed it (bypassed the PR process). |
Merged
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #654