Remove unused selectedRow logic #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverjam
approved these changes
Sep 8, 2022
john-michaelburke
approved these changes
Sep 12, 2022
These are remnants of a prior selection method that are no longer used. Unnecessary updating of this selectedRow variable is made when no one is accessing it.
keithel-qt
force-pushed
the
keithel-qt/remove-unused-selectedrow
branch
from
9f87ee1 to
6a2d6dd
Compare
|
Any reason this isn't being merged? |
|
We usually let the author merge in case any last minute changes come up. |
john-michaelburke
approved these changes
Sep 13, 2022
|
@john-michaelburke looks like something is stuck on macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are remnants of a prior selection method that are no longer used. Unnecessary updating of this selectedRow variable is made when no one is accessing it.