Skip to content

Remove unused selectedRow logic #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Remove unused selectedRow logic #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions resources/Constants/Globals.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,10 @@ QtObject {
property int minimumWidth: 900
property string conn_state: Constants.connection.disconnected.toUpperCase()
property string copyClipboard: ""
property var tablesWithHighlights: []
property var currentSelectedTable: null
property bool showFileConnection: false
property QtObject updateTabData

function clearHighlightedRows() {
for (var i in tablesWithHighlights) {
tablesWithHighlights[i].selectedRow = -1;
}
}

updateTabData: QtObject {
property bool consoleOutdated: false
property bool fwV2Outdated: false
Expand Down
2 changes: 0 additions & 2 deletions resources/LogPanel.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,6 @@ Item {
rows.unshift(new_row);
tableView.model.rows = rows.slice(0, Constants.logPanel.maxRows);
}
if (logPanelData.entries.length && tableView.selectedRow != -1)
tableView.selectedRow += logPanelData.entries.length;
logPanelData.entries = [];
}
}
Expand Down
1 change: 0 additions & 1 deletion resources/TableComponents/SwiftTableView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ TableView {
property alias verticalScrollBar: _verticalScrollBar
property variant columnWidths: []
property variant columnAlignments: []
property int selectedRow: -1
property int _currentSelectedIndex: -1
property bool stayFocused: false
property int currentSelectedIndex: (!stayFocused && Globals.currentSelectedTable == this) ? _currentSelectedIndex : -1
Expand Down