event based recording status [CPP-843]

[adrian-kong]

removes logging thread, send smaller packets of changes,
defers the full state to the frontend.
we can also refactor this into the event receivers that was introduced in instant filter updates etc...

downside is we send whenever we receive a frame meaning it would be dependent on the stream of info - which we can do some batching if this happen (too many updates for frontend gui => laggy ?)

this is also to prepare for another ticket - record empty streams of data

[adrian-kong]

@john-michaelburke wanted to get some thoughts on these changes,

only broken thing atm with these changes is SBP_JSON does not accurately reflect bytes written (will create another PR in dencode / libsbp to reflect # of bytes sent when using send function in encoders)

These changes aims to allow for more "responsive" update via events rather than waiting thread,
This also removes the need to use threading as well as minimizing capnproto packet size by sending only what is needed and compute the rest in frontend (less resources and cleaner)

Using these changes ...

Screen.Recording.2022-12-13.at.4.16.06.pm.mov

Using main branch ...

Screen.Recording.2022-12-13.at.4.14.51.pm.mov

[john-michaelburke]

Definitely not opposed to moving the logic to the frontend/python. There are a few minor details that would get flagged by Stefan I imagine. I believe all of these were covered by the previous implementation (famous last words).
First, I see some wonky behavior if you delete the file or containing folder while it is still recording. Somehow the file size continues to grow but the file does not exist and does not get written to after stopping the recording.
Second, when stopping a recording the file duration/size from the previous recording lingers. Stefan had asked for this to get cleared whenever a recording was stopped.
Screencast from 12-13-2022 09:52:59 AM.webm
Third, (no video for this), if you start a recording from the command line, the dropdown selection does not reflect the type of recording that was requested. For example if you start an SBP log from the cli, the dropdown will show the default SBP_JSON selected. It does properly record the sbp file though so just a minor bug.

[john-michaelburke]

Also it appears the manual filename selector to select the filename for a recording is broken. I get this error:

qrc:/Constants/utils.js:9: TypeError: Cannot call method 'toString' of undefined

[silverjam]

looks good, but I'll echo @john-michaelburke's concerns/requests

[silverjam]

Failing code quality checks, what else is remaining for this PR?

[adrian-kong]

Failing code quality checks, what else is remaining for this PR?

was working on other tickets this will need to go back into WIP from the received reviews

[swiftnav-travis]

Frontend and Release Workflow Started here

[adrian-kong]

all behaviours as mentioned should be resolved now 👍

[swiftnav-travis]

Frontend and Release Workflow Started here

[adrian-kong]

will need to merge this in before re-releasing. (addresses some bugs & improvements, test if notarytool works)

[swiftnav-travis]

Frontend and Release Workflow Started here

[ziwift]

lgtm