Skip to content

Fix build break in non-iOS platforms. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix build break in non-iOS platforms. #110

merged 1 commit into from
Aug 30, 2022

Conversation

@lardieri
Copy link
Contributor

@lardieri lardieri commented Aug 29, 2022

Need to add the new source file to all platform targets.

@lardieri
Fix build break in non-iOS platforms.
d2b127c 
Need to add the new source file to all platform targets.
@lardieri
Copy link
Contributor Author

lardieri commented Aug 29, 2022

Curious why the CI pipeline didn't catch this.

@lardieri lardieri mentioned this pull request Aug 29, 2022
Merged
@DivineDominion
Copy link
Contributor

DivineDominion commented Aug 30, 2022

CI uses swift build and doesn't interact with Xcode. It basically just tests SwiftPM that way. It might pay off to add another build step to the workflow; will open an enhancement issue for that

DivineDominion
DivineDominion approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@DivineDominion DivineDominion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lardieri lardieri merged commit 8244fd6 into swiftcsv:master Aug 30, 2022
@lardieri lardieri deleted the fixBuild branch August 30, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DivineDominion DivineDominion DivineDominion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lardieri @DivineDominion