Fix serialization of embedded quotes. #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Didn't even know about this, to be honest. Oof!
(When #110 is merged, you should be able to rebase this branch on master and resolve the duplicated commit regarding the project fixes.)
When paging through the CSV RFC of 2005, I saw they want us to use CRLF newlines instead of just \n. https://www.rfc-editor.org/rfc/rfc4180.html -- maybe we should change the serializer to reflect that eventually. (Not in this PR)
DivineDominion
approved these changes
Aug 30, 2022
|
Sorry -- I'm bad at remembering this, but please add a CHANGELOG entry for this fix/change :) |
3 tasks
Embedded quotes in values must be doubled, and the entire value surrounded with quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded quotes in values must be doubled, and the entire value surrounded with quotes.
Includes commit from #110 because otherwise we'd get merge conflicts in the project file.