[sil] Eliminate end_borrow_argument now that end_borrow has a single … #19131
+40
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-67d16ab8862dce3cff561b2a4dbee16514133383
branch
from
c2ea7bb to
db5189b
Compare
Contributor
Author
|
While looking at those failing tests I discovered we aren't strictly verifying guaranteed arguments as much as we can. The behavior that we want is that a guaranteed argument must be contained strictly within the parent borrowed scope. I have an additional commit that is going to tighten this up and adds a bunch of tests to check the behavior. |
Contributor
Author
|
It is ok to ignore that for now since SILGen doesn't emit +0 non-function arguments. |
Contributor
Author
|
@swift-ci smoke test and merge |
2 similar comments
Contributor
Author
|
@swift-ci smoke test and merge |
Contributor
Author
|
@swift-ci smoke test and merge |
…operand. I changed all of the places that used end_borrow_argument to use end_borrow. NOTE: I discovered in the process of this patch that we are not verifying guaranteed block arguments completely. I disabled the tests here that show this bad behavior and am going to re-enable them with more tests in a separate PR. This has not been a problem since SILGen does not emit any such arguments as guaranteed today. But once I do the SILGenPattern work this will change. rdar://33440767
gottesmm
force-pushed
the
pr-67d16ab8862dce3cff561b2a4dbee16514133383
branch
from
db5189b to
0290cd4
Compare
Contributor
Author
|
Lets try this one last time. |
Contributor
Author
|
@swift-ci smoke test and merge |
2 similar comments
Contributor
Author
|
@swift-ci smoke test and merge |
Contributor
Author
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…operand.
I changed all of the places that used end_borrow_argument to use end_borrow.
rdar://33440767