[sil-ownership] Tighten up the verification of guaranteed phi arguments. #19173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
The other PR is #19131 |
Contributor
|
Build failed |
Now we properly enforce that all guaranteed phi arguments's lifetime is completely enclosed by the lifetimes of the phi argument's inputs. This is implemented by inserting an "implicit" regular use into the use stream of the phi argument's inputs. This is nice since it ensures that when we are verifying ownership of a specific argument, we will not walk through all subarguments... instead we just need to verify that the end_borrow is completely enclosed within the lifetime of the input guaranteed value. I also fixed a case where we were bailing early out of the SIL Ownership Verifier causing us to emit an incorrect error. This error would only occur if we already diagnosed an error. I also re-added all of the tests that I removed when I replaced end_borrow_argument with end_borrow. rdar://33440767
gottesmm
force-pushed
the
pr-0290cd4323dba0b496df6aaa44c48ee171f647fa
branch
from
a49a829 to
42498ad
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
Was an lldb build failure. Not related to my change. Retesting! |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@atrick Lets do post-commit review. I want to land this so I can finish splitting the ownership verifier into two so we can classify operand's acceptable ownership statically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we properly enforce that all guaranteed phi arguments's lifetime is
completely enclosed by the lifetimes of the phi argument's inputs. This is
implemented by inserting an "implicit" regular use into the use stream of the
phi argument's inputs. This is nice since it ensures that when we are verifying
ownership of a specific argument, we will not walk through all
subarguments... instead we just need to verify that the end_borrow is completely
enclosed within the lifetime of the input guaranteed value.
I also fixed a case where we were bailing early out of the SIL Ownership
Verifier causing us to emit an incorrect error. This error would only occur if
we already diagnosed an error.
I also re-added all of the tests that I removed when I replaced
end_borrow_argument with end_borrow.
rdar://33440767