Allow to configure the JS exclude rules through configureBabel #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
babel-exclude-config
branch
from
cf28209 to
71793c0
Compare
Lyrkan
force-pushed
the
babel-exclude-config
branch
2 times, most recently
from
11c911e to
f05d4d2
Compare
Lyrkan
force-pushed
the
babel-exclude-config
branch
from
f05d4d2 to
714a732
Compare
weaverryan
approved these changes
Oct 19, 2018
index.js
Outdated
| * // change the babelConfig | ||
| * }, { | ||
| * // set optional Encore-specific options | ||
| * // exclude: /(node_modules|bower_components)/ |
Member
There was a problem hiding this comment.
Small detail: but could we add include_node_modules here too with a decent example? It's documented below, but at first glance, I thought this was the only option :)
|
|
||
| if (!Array.isArray(options[optionKey])) { | ||
| throw new Error('Option "include_node_modules" passed to configureBabel() must be an Array.'); | ||
| } |
Member
There was a problem hiding this comment.
Great error checking and messages as usual!
Lyrkan
force-pushed
the
babel-exclude-config
branch
from
5deed94 to
a07238c
Compare
Member
|
Thank you @Lyrkan! Great work as usual! |
weaverryan
added a commit
that referenced
this pull request
Oct 26, 2018
…eBabel (Lyrkan) This PR was squashed before being merged into the master branch (closes #401). Discussion ---------- Allow to configure the JS exclude rules through configureBabel This PR closes #342 by allowing to configure the js/jsx loaders' exclude rule by using `configureBabel()`. For instance: ```js Encore.configureBabel( () => {}, { exclude: /foo/ } ); ``` Note that it doesn't change the default behavior that excludes `node_modules` and `bower_components`. **Edit:** Also adds an `include_node_modules` option to use the default `exclude` rule but only include some Node modules (can't be used if the `exclude` option is also set): ```js Encore.configureBabel( () => {}, { include_node_modules: ['foo', 'bar', 'baz'] } ); ``` Commits ------- a07238c Add an example of calling configureBabel with the "include_node_modules" option 714a732 Add "include_node_modules" option to configureBabel 6c8f073 Allow to configure the JS exclude rules through configureBabel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #342 by allowing to configure the js/jsx loaders' exclude rule by using
configureBabel().For instance:
Note that it doesn't change the default behavior that excludes
node_modulesandbower_components.Edit:
Also adds an
include_node_modulesoption to use the defaultexcluderule but only include some Node modules (can't be used if theexcludeoption is also set):