[Bug] Cancelled workflow returns WorkflowExecutionStatus.FAILED status in workflow description

[lambyqq]

What are you really trying to do?

Cancel a running workflow and check the status in wf_handle.describe().status

Describe the bug

Expect the status to be WorkflowExecutionStatus.CANCELED, but got WorkflowExecutionStatus.FAILED

Minimal Reproduction

cancel a workflow and get its status

Environment/Versions

• Temporal Version: [e.g. 1.14.0?] and/or SDK version
  python-SDK: temporalio==0.1b1

Additional context

I have to use a workaround to tell if workflow is cancelled:

wf_description.status == WorkflowExecutionStatus.FAILED
            and isinstance(wf_error.cause, CancelledError)

[cretz]

Thanks, I have confirmed at

sdk-python/temporalio/worker/workflow_instance.py

Lines 1229 to 1236 in 49ccd56

	except asyncio.CancelledError as err:
	command = self._add_command()
	command.fail_workflow_execution.failure.SetInParent()
	temporalio.exceptions.apply_exception_to_failure(
	temporalio.exceptions.CancelledError(str(err)),
	self._payload_converter,
	command.fail_workflow_execution.failure,
	)

we are not doing the right thing. We will solve this shortly.

Note to self/implementer:

• Change to cancel_workflow_execution instead of fail_workflow_execution and confirm in tests
• Confirm in tests what happens if a cancellation error is raised outside of a cancellation request