Skip to content

Minor updates #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2022
Merged

Minor updates #186

merged 5 commits into from
Nov 7, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Nov 3, 2022

What was changed

  • Add temporalio.client.WorkflowQueryFailedError instead of just RPCError
  • Properly report workflow cancellation on bubbled cancel errors
  • Add metric temporality config option to telemetry init
  • Add favicon to docs

Checklist

  1. Closes [Bug] Wrap query RPC error with friendlier error #162
  2. Closes [Bug] Cancelled workflow returns WorkflowExecutionStatus.FAILED status in workflow description #145
  3. Closes [Feature Request] Support Otel temporality config #141
  4. Closes [Feature Request] Better title and favicon for python.temporal.io #140

@cretz cretz requested a review from a team November 3, 2022 17:44
@cretz
Merge remote-tracking branch 'remotes/origin/main' into misc-updates3
6534132 
# Conflicts:
#	temporalio/worker/_workflow_instance.py
@cretz cretz merged commit 2546871 into temporalio:main Nov 7, 2022
@cretz cretz deleted the misc-updates3 branch November 7, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@cretz @Quinn-With-Two-Ns