[Bug] Python 3.11 TypeError: Passing coroutines is forbidden, use tasks explicitly.

[AndrewIngram]

The following lines of code run without issue in Python 3.10, but throw in 3.11:

await asyncio.wait(
    [asyncio.sleep((snooze_until - now).total_seconds()), self._is_reopened.wait()],
    return_when=asyncio.FIRST_COMPLETED,
)

(this is similar to an example in the readme, so it seems idiomatic)

The error I get in 3.11 is TypeError: Passing coroutines is forbidden, use tasks explicitly.

Encountered on the python:3.11-slim Docker image, initially using temporalio=0.1b3, reproduced on 0.1b4

I think the relevant Python docs are https://docs.python.org/3/library/asyncio-task.html#waiting-primitives

Passing coroutine objects to wait() directly is forbidden

Not sure if I'd class it as a bug, as the change in Python appears to be deliberate, but it means the canonical way to solve this in Temporal might now be different?

[cretz]

This is a known Python change and unrelated to Temporal. Why use wait with a sleep instead of just sleep? Also, when using wait, you need a task. So use create_task or similar.

I will update the README to use tasks.

[AndrewIngram]

I'm not sure I understand your question, I want to wait for a specific time, or an event, whichever happens first.

But I hit the same issue even without the sleep and just using wait on the event (as per the readme example), so i'm keen to see what the canonical way of doing this is -- i'd been assuming it was what's in the readme.

[cretz]

Sorry, my mobile phone cut off the right part, I see the event wait now.

The proper way since Python 3.11 is to use tasks (so wrap your pieces in create_task). We just haven't updated the README yet. This is not Temporal specific, you'd do the same thing using normal asyncio in Python 3.11.

[cretz]

Though to wait for something until timeout, wait_for is the better approach

[AndrewIngram]

Do you mean like this (which seems to work in 3.11)?

try:
    await asyncio.wait_for(
        self._is_reopened.wait(), timeout=(snooze_until - now).total_seconds()
    )
except TimeoutError:
    pass

[AndrewIngram]

Do you want me to leave this open so you can track the readme change, or close it?

[cretz]

That wait_for example looks fine. Yes you can leave this open for me to update the README.

The best practice is to use asyncio in Temporal like you would outside of Temporal.

[AndrewIngram]

Easier said then done when this is our first time using async Python in anger after a 15+ years of non-async Python :)