Skip to content

Conversation

@cretz
Copy link
Member

@cretz cretz commented Jan 4, 2023

What was changed

  • Properly support Optional params in workflows/activities
  • Make sure that we don't try to send cancelled error to server on worker shutdown (was only caused by the recent Support raising cancellation in sync multithreaded activities #217)
  • Updated README to note that generic types are not resolved for purposes of deserialization
  • Updated README to properly use asyncio.create_task for calls to asyncio.wait since 3.11 requires that now

Checklist

  1. Closes [Bug] Python 3.11 TypeError: Passing coroutines is forbidden, use tasks explicitly. #232
  2. Closes [Bug] Generic Nested Dataclasses not desrialized correctly #234
  3. Closes [Bug] Optional[X] type not being handled properly as parameter #236
  4. Closes [Bug] Activity cancellation error issues #237

@cretz cretz requested a review from a team January 4, 2023 15:56
@cretz cretz merged commit 57bf9e6 into temporalio:main Jan 4, 2023
@cretz cretz deleted the misc-updates6 branch January 4, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants