[Bug] Wrong line number in workflow.logger

[ndtretyak]

Describe the bug

All the log records emitted by workflow.logger has the same file, path and lineno pointing to workflow.LoggingAdapter.log.

Minimal Reproduction

import logging
import sys

from temporalio import workflow


class Formatter(logging.Formatter):
    def format(self, record) -> str:
        return f"path: {record.pathname}"


formatter = Formatter()
handler = logging.StreamHandler(sys.stdout)
handler.setFormatter(formatter)
log = logging.getLogger("")
log.setLevel(logging.INFO)
log.addHandler(handler)


@workflow.defn
class Workflow:
    @workflow.run
    async def run(self) -> None:
        workflow.logger.info("message")

This prints <...>/temporalio/workflow.py instead of the file where workflow is defined.

[cretz]

Thanks for the report!

I have confirmed this is due to us overriding LogAdapter.log to prevent logging during replay. The best fix is probably for us to remove the log overload and replace it with:

    def isEnabledFor(self, level: int) -> bool:
        return super().isEnabledFor(level) and (self.log_during_replay or not unsafe.is_replaying())