Skip to content

Fix line number in workflow.logger #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix line number in workflow.logger #460

merged 1 commit into from
Jan 10, 2024

Conversation

ndtretyak
Copy link
Contributor

What was changed

Now, workflow.LoggingAdapter overrides isEnabledFor, which does not add additional stack frame during logging, instead of log.

Why?

To have correct line numbers in logs.

Checklist

  1. Closes [Bug] Wrong line number in workflow.logger #447

  2. How was this tested:
    Unit test

  3. Any docs updates needed?
    No

@ndtretyak ndtretyak requested a review from a team as a code owner January 10, 2024 15:43
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cretz
cretz approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge if/when CI passes.

@cretz cretz merged commit e3630ef into temporalio:main Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cretz cretz cretz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Wrong line number in workflow.logger

3 participants

@ndtretyak @CLAassistant @cretz